Update APIVerificationTests.cs#2391
Conversation
| public class DaydreamController : UnityEngine.InputSystem.XR.XRController | ||
| public class GearVRTrackedController : UnityEngine.InputSystem.XR.XRController | ||
| public class OculusTouchController : UnityEngine.InputSystem.XR.XRControllerWithRumble | ||
| public class HandedViveTracker : ViveTracker |
There was a problem hiding this comment.
The base class ViveTracker is the only one in this list missing the UnityEngine.InputSystem.XR namespace prefix. If the API scraper provides fully qualified names (as it seems to for the other controllers like DaydreamController), this exclusion might not match and could fail to suppress the intended output. Please verify if it should be UnityEngine.InputSystem.XR.ViveTracker.
🤖 Helpful? 👍/👎
| public class ViveWand : UnityEngine.InputSystem.XR.XRControllerWithRumble | ||
| ")] | ||
| // API scraper in 1.0.0 emitted incomplete default argument expressions for these overloads. | ||
| [Property("Exclusions", @"1.0.0 |
There was a problem hiding this comment.
There are now multiple separate [Property("Exclusions", ...)] attributes for version 1.0.0. While this helps organize them by the reason for exclusion, it repeats the version header and the property key. Have you considered consolidating these into a single block or using a more structured way to manage exclusions to reduce duplication and potential maintenance overhead when adding new versions?
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2391 +/- ##
=========================================
Coverage 77.90% 77.91%
=========================================
Files 476 482 +6
Lines 97613 97756 +143
=========================================
+ Hits 76048 76168 +120
- Misses 21565 21588 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
Please fill this section with a description what the pull request is trying to address and what changes were made.
Testing status & QA
Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.