Fix cubemap & video clip reporting#18
Open
projects-rr wants to merge 1 commit intoUnity-Technologies:mainfrom
Open
Fix cubemap & video clip reporting#18projects-rr wants to merge 1 commit intoUnity-Technologies:mainfrom
projects-rr wants to merge 1 commit intoUnity-Technologies:mainfrom
Conversation
525d747 to
2dd34ca
Compare
Collaborator
|
Thanks for the submission, and sorry for long delay in responding it. The underlying code for adding new types has evolved a bit but adding a table for Video objects makes sense and would be pretty low risk. However it will take a bit of testing and ideally adding a example file with a tiny video inside it for automated test coverage. I don't know enough about the ins and outs of Textures and how they are serialized to judge if there could be any special concern with adding the image count column. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cubemaps & video clips do not currently have their size properly reported.
Add Cubemaps to the existing texture data, along with the 'ImageCount' field. Note, the files for this are called Texture2D*, but the databases are texture*, so they seem like the proper place to put all texture types. This code should potentially get updated for other texture types (Texture3D, Texture2DArray, etc...) however I don't have example content to test this with right now.
Add video clips to their own database & view