fix: reset static fields for Fast Enter Play Mode#3956
Open
noellie-velez wants to merge 17 commits into
Open
Conversation
# Conflicts: # com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs
noellie-velez
commented
Apr 24, 2026
noellie-velez
commented
Apr 24, 2026
noellie-velez
commented
Apr 24, 2026
simon-lemay-unity
approved these changes
Apr 24, 2026
Contributor
simon-lemay-unity
left a comment
simon-lemay-unity
left a comment
There was a problem hiding this comment.
Changes to UnityTransport look good to me.
# Conflicts: # com.unity.netcode.gameobjects/Runtime/Logging/NetworkLog.cs
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
| @@ -44,6 +44,10 @@ public static class QuaternionCompressor | |||
|
|
|||
| // Used to store the absolute value of the 4 quaternion elements | |||
| private static Quaternion s_QuatAbsValues = Quaternion.identity; | |||
Collaborator
Author
There was a problem hiding this comment.
Replace quaternion by 4 ints
Collaborator
Author
There was a problem hiding this comment.
If replacing this quaternion by 4 ints, we would need to rework the index to skip logic (lines 70 to 95)
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
| DisableNotOptimizedSerializedType = false; | ||
| } | ||
|
|
||
| private void Reset() |
Collaborator
Author
There was a problem hiding this comment.
Add xml doc with:
Used by cref... NetworkManagerHeper this is called by the reset button of the Unity Editor
Collaborator
Author
There was a problem hiding this comment.
Did not manage to have the correct cref link
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
| @@ -13,6 +16,18 @@ internal class NetworkMetrics : INetworkMetrics | |||
| private const ulong k_MaxMetricsPerFrame = 1000L; | |||
| private static Dictionary<uint, string> s_SceneEventTypeNames; | |||
Collaborator
Author
There was a problem hiding this comment.
this can be made readonly
Collaborator
Author
There was a problem hiding this comment.
s_FrameDispatch too?
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
EmandM
reviewed
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 18, 2026
| internal static readonly int AnimatorControllerParameterInt; | ||
| internal static readonly int AnimatorControllerParameterFloat; | ||
| internal static readonly int AnimatorControllerParameterBool; | ||
| internal static readonly int AnimatorControllerParameterTriggerBool; |
Collaborator
Author
There was a problem hiding this comment.
This is not being used, are we missing a cacheValue.Type == AnimationParamEnumWrapper.AnimatorControllerParameterTriggerBool check on ReadParameters function (line 1386)?
noellie-velez
commented
May 18, 2026
| /// For debugging delta position and half vector3 | ||
| /// </summary> | ||
| protected delegate void AddLogEntryHandler(ref NetworkTransformState networkTransformState, ulong targetClient, bool preUpdate = false); | ||
| protected AddLogEntryHandler m_AddLogEntry; |
Collaborator
Author
There was a problem hiding this comment.
Is m_AddLogEntry being used?
…gies/com.unity.netcode.gameobjects into chore/fast-enter-playmode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ensure com.unity.netcode.gameobjects package supports Fast Enter Play Mode
Jira ticket
MTT-14665
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
N/A