Skip to content

fix: end TransportConnect profiler marker on early returns in ConnectEventHandler #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoelStephensUnity merged 2 commits into from
Jun 2, 2026
+6 −0
Merged

fix: end TransportConnect profiler marker on early returns in ConnectEventHandler #4005

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
741c2fb
fix: end TransportConnect profiler marker on early returns in Connect…
mnachury-unity Jun 1, 2026
5916ec4
Merge branch 'develop-2.0.0' into fix/transport-connect-profiler-mark…
mnachury-unity Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions com.unity.netcode.gameobjects/Runtime/Connection/NetworkConnectionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,9 @@ internal void ConnectEventHandler(ulong transportId)
{
NetworkLog.LogError($"[TransportApproval][Server] TransportId {transportId} is already connected to this server!");
}
#if DEVELOPMENT_BUILD || UNITY_EDITOR
s_TransportConnect.End();
#endif
return;
}

Expand All @@ -536,6 +539,9 @@ internal void ConnectEventHandler(ulong transportId)
{
NetworkLog.LogError("[TransportApproval][Client] Client received a transport connection event after already connecting!");
}
#if DEVELOPMENT_BUILD || UNITY_EDITOR
s_TransportConnect.End();
#endif
return;
}

Expand Down