Skip to content

More flexible Windows checks #2909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 1 commit into from
Feb 13, 2026
Merged

More flexible Windows checks #2909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/mock_vws/test_docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,16 @@ def test_build_and_run(
full_log = "\n".join(
[item["stream"] for item in exc.build_log if "stream" in item],
)
windows_message_substrings = (
"no matching manifest for windows/amd64",
"no matching manifest for windows(10.0.26100)/amd64",
)
# If this assertion fails, it may be useful to look at the other
# properties of ``exc``.
if "no matching manifest for windows/amd64" not in exc.msg:
if not any(
windows_message_substring in exc.msg
for windows_message_substring in windows_message_substrings
):
raise AssertionError(full_log) from exc
pytest.skip(
reason="We do not currently support using Windows containers."
Expand Down
Loading