Make pyrefly non-exhaustive-match an error#2916
Merged
adamtheturtle merged 3 commits intomainfrom Feb 15, 2026
Merged
Conversation
- Configure pyrefly to treat non-exhaustive-match as an error instead of a warning so it fails the build. - Add wildcard case branches to match statements to make them exhaustive.
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
non-exhaustive-matchas an error instead of a warning so it fails the build.case _:branches to match statements to make them exhaustive.Note
Medium Risk
Workflow changes affect the release pipeline (tag/checkout, PyPI and Docker publishing) and could break releases if outputs/refs are miswired; code changes are low-impact but touch runtime enum matching paths.
Overview
Hardens static analysis by configuring
pyreflyto treatnon-exhaustive-matchas an error, and updates the affectedmatchstatements intarget_manager.py,vws.py, andvwq.pyto include acase _:fallback that raisesValueError.Refactors the release GitHub Action by splitting the workflow into
release(tag + GitHub release),pypi(build/publish to PyPI), anddocker(build/push images) jobs, wiring them via joboutputsso publishing builds from the exact release tag/version (and no longer manuallygit checkouts).Written by Cursor Bugbot for commit fc05712. This will update automatically on new commits. Configure here.