-
Notifications
You must be signed in to change notification settings - Fork 2
Add initial VuMark generation API test #2931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d2b383a
Add minimal VuMark API interaction test
adamtheturtle a133585
Share VuMark credentials across secrets files
adamtheturtle 00a5951
Set VuMark test Accept header
adamtheturtle f8c083c
Make VuMark test assert successful generation
adamtheturtle 9efcf5e
Use VuMark fixture fields in generation test
adamtheturtle 18cedb6
Update CI workflow and remove VuMark test skip logic
adamtheturtle 6d87404
Generate VuMark instance IDs in test instead of env settings
adamtheturtle dfd0bde
Refactor secrets generation to initialize VuMark data once
adamtheturtle d65bccf
Fix typing in VuMark setup refactor
adamtheturtle a762e69
Remove redundant VuMark None check for pyright
adamtheturtle ee59318
Skip VuMark provisioning when no secrets files are missing
adamtheturtle 2ea8843
Merge origin/main into adamtheturtle/vumark-api-test
adamtheturtle 9409d2e
Merge origin/main into adamtheturtle/vumark-api-test
adamtheturtle 381878f
Merge remote-tracking branch 'origin/main' into adamtheturtle/vumark-…
adamtheturtle 79bad8d
Merge origin/main into adamtheturtle/vumark-api-test
adamtheturtle f706b1a
Reset VuMark secrets files to origin/main
adamtheturtle 7dcfeef
Add mock VuMark instance generation support and class-based test
adamtheturtle 9cd8765
Fix generator teardown pattern in backend fixture
adamtheturtle bf6ed8c
Merge remote-tracking branch 'origin/main' into adamtheturtle/vumark-…
adamtheturtle 43e2ac6
Add VuMark target setup to mock backends
adamtheturtle bf8224a
Fix BugBot issues for VuMark support
adamtheturtle fbae231
Fix mypy typing in target validator test
adamtheturtle 6dea443
Resolve pyright typing in validator test
adamtheturtle 941348f
Remove uncovered branches from generate_vumark_instance
adamtheturtle 5442a76
Use valid default target ID for VuMark database settings
adamtheturtle 270f9d9
Use valid target ID placeholder in vuforia_secrets.env.example
adamtheturtle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing ValidatorError handling in VuMark route handler
High Severity
The
generate_vumark_instancemethod in the requests-mock server callsrun_services_validatorswithout wrapping it intry/except ValidatorError, unlike every other route handler in this file. When validation fails (e.g., bad auth, unknown target, missing keys), theValidatorErrorpropagates as an unhandled exception through theresponsesmock callback instead of being converted into a proper HTTP error response viaexc.status_code,exc.headers,exc.response_text.