Move create_secrets_files env reads into main#2936
Merged
adamtheturtle merged 2 commits intomainfrom Feb 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors admin/create_secrets_files.py so helper functions no longer read from os.environ directly. main() now reads the inactive database environment variables once and passes them through as inactive_database_details. _generate_secrets_file_content() was updated to accept that data and use it when writing the inactive key values. No behavior changes are intended beyond centralizing environment access in main().
Note
Low Risk
Low risk refactor limited to a dev/admin script; behavior should be unchanged aside from when missing inactive env vars are detected (now read once in
main()).Overview
Refactors
admin/create_secrets_files.pyso inactive Vuforia credentials are read once inmain()(afterload_dotenv) and passed into_generate_secrets_file_content()asinactive_database_details, instead of the helper readingos.environdirectly.The generated secrets files now populate the
INACTIVE_*entries from that passed-in dict, improving separation of concerns and centralizing environment access.Written by Cursor Bugbot for commit d473c78. This will update automatically on new commits. Configure here.