Skip to content

Use vws-web-tools upload for VuMark target IDs#2937

Merged
adamtheturtle merged 1 commit intomainfrom
adamtheturtle/create-pr
Feb 17, 2026
Merged

Use vws-web-tools upload for VuMark target IDs#2937
adamtheturtle merged 1 commit intomainfrom
adamtheturtle/create-pr

Conversation

@adamtheturtle
Copy link
Member

@adamtheturtle adamtheturtle commented Feb 17, 2026

Updates the secrets generation flow to obtain VuMark target IDs via vws_web_tools.upload_vumark_template instead of reading a shared target ID from environment variables.
admin/create_secrets_files.py now creates a temporary SVG template, uploads it, and writes the returned VUMARK_VUFORIA_TARGET_ID to each generated secrets file with existing retry/timeout behavior.
The change also bumps vws-web-tools to 2026.2.17 and documents VUMARK_VUFORIA_TARGET_ID in vuforia_secrets.env.example.


Note

Medium Risk
Changes the automated secrets/provisioning flow by adding a new web-driven upload step and relying on vws-web-tools return types, which could fail or change across versions.

Overview
Secrets generation (admin/create_secrets_files.py) now uploads a VuMark template to fetch a VuMark target_id and writes it into each generated secrets file as VUMARK_VUFORIA_TARGET_ID (including retry/timeout handling).

Adds a temporary SVG template and per-run resource naming helper, bumps vws-web-tools to 2026.2.17, and updates vuforia_secrets.env.example to document the new VUMARK_VUFORIA_TARGET_ID entry.

Written by Cursor Bugbot for commit 0826fc0. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

)
driver.quit()
driver = None
continue
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unhandled upload result leaks browser driver

Low Severity

main only handles TimeoutException around _create_and_get_vumark_target_id. When upload_vumark_template returns an unexpected shape, _create_and_get_vumark_target_id raises RuntimeError, which bypasses cleanup and leaves driver running. This can terminate admin/create_secrets_files.py early and leak browser processes.

Additional Locations (1)

Fix in Cursor Fix in Web

@adamtheturtle adamtheturtle merged commit 0826fc0 into main Feb 17, 2026
101 of 105 checks passed
@adamtheturtle adamtheturtle deleted the adamtheturtle/create-pr branch February 17, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant