Use vws-web-tools upload for VuMark target IDs#2937
Merged
adamtheturtle merged 1 commit intomainfrom Feb 17, 2026
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| ) | ||
| driver.quit() | ||
| driver = None | ||
| continue |
There was a problem hiding this comment.
Unhandled upload result leaks browser driver
Low Severity
main only handles TimeoutException around _create_and_get_vumark_target_id. When upload_vumark_template returns an unexpected shape, _create_and_get_vumark_target_id raises RuntimeError, which bypasses cleanup and leaves driver running. This can terminate admin/create_secrets_files.py early and leak browser processes.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Updates the secrets generation flow to obtain VuMark target IDs via
vws_web_tools.upload_vumark_templateinstead of reading a shared target ID from environment variables.admin/create_secrets_files.pynow creates a temporary SVG template, uploads it, and writes the returnedVUMARK_VUFORIA_TARGET_IDto each generated secrets file with existing retry/timeout behavior.The change also bumps
vws-web-toolsto2026.2.17and documentsVUMARK_VUFORIA_TARGET_IDinvuforia_secrets.env.example.Note
Medium Risk
Changes the automated secrets/provisioning flow by adding a new web-driven upload step and relying on
vws-web-toolsreturn types, which could fail or change across versions.Overview
Secrets generation (
admin/create_secrets_files.py) now uploads a VuMark template to fetch a VuMarktarget_idand writes it into each generated secrets file asVUMARK_VUFORIA_TARGET_ID(including retry/timeout handling).Adds a temporary SVG template and per-run resource naming helper, bumps
vws-web-toolsto2026.2.17, and updatesvuforia_secrets.env.exampleto document the newVUMARK_VUFORIA_TARGET_IDentry.Written by Cursor Bugbot for commit 0826fc0. This will update automatically on new commits. Configure here.