Skip to content

Use vws-web-tools upload for VuMark target IDs#2938

Merged
adamtheturtle merged 7 commits intomainfrom
adamtheturtle/pr-vumark-svg
Feb 17, 2026
Merged

Use vws-web-tools upload for VuMark target IDs#2938
adamtheturtle merged 7 commits intomainfrom
adamtheturtle/pr-vumark-svg

Conversation

@adamtheturtle
Copy link
Member

@adamtheturtle adamtheturtle commented Feb 17, 2026

Updates the secrets generation flow to obtain VuMark target IDs via vws_web_tools.upload_vumark_template instead of reading a shared target ID from environment variables.
admin/create_secrets_files.py now creates a temporary SVG template, uploads it, and writes the returned VUMARK_VUFORIA_TARGET_ID to each generated secrets file with existing retry/timeout behavior.
The change also bumps vws-web-tools to 2026.2.17 and documents VUMARK_VUFORIA_TARGET_ID in vuforia_secrets.env.example.


Note

Medium Risk
Changes the secrets-generation flow to create and upload a VuMark template via Selenium and persist the returned target ID; failures/timeouts or Vuforia UI changes could break CI/test setup. Dependency bump to vws-web-tools may also subtly change automation behavior.

Overview
Secrets generation now creates a VuMark template on the fly and derives VUMARK_VUFORIA_TARGET_ID from Vuforia instead of relying on a pre-shared ID. admin/create_secrets_files.py uploads admin/vumark_template.svg via vws_web_tools.upload_vumark_template, fetches the target ID, and writes it into each generated secrets file (with existing timeout/retry handling).

Updates the example env file to include VUMARK_VUFORIA_TARGET_ID, and bumps vws-web-tools to 2026.2.17.1 to support the new automation.

Written by Cursor Bugbot for commit 206f379. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

)

return RETRY_ON_TIMEOUT(vws_web_tools.get_database_details)(
return vws_web_tools.get_database_details(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tenacity retry logic silently removed from API calls

Medium Severity

The RETRY_ON_TIMEOUT tenacity decorator (which retried up to 3 times with exponential backoff) was removed from the get_database_details and get_vumark_database_details calls, but the PR description claims "existing retry/timeout behavior" is preserved. Now a single transient TimeoutException immediately triggers the outer loop's recovery path, which quits the driver and recreates all resources from scratch—far more expensive than the previous in-place retry with backoff. The new upload_vumark_template call also lacks any retry logic.

Additional Locations (1)

Fix in Cursor Fix in Web

@adamtheturtle adamtheturtle merged commit a12c022 into main Feb 17, 2026
102 checks passed
@adamtheturtle adamtheturtle deleted the adamtheturtle/pr-vumark-svg branch February 17, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments