Use vws-web-tools upload for VuMark target IDs#2938
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| ) | ||
|
|
||
| return RETRY_ON_TIMEOUT(vws_web_tools.get_database_details)( | ||
| return vws_web_tools.get_database_details( |
There was a problem hiding this comment.
Tenacity retry logic silently removed from API calls
Medium Severity
The RETRY_ON_TIMEOUT tenacity decorator (which retried up to 3 times with exponential backoff) was removed from the get_database_details and get_vumark_database_details calls, but the PR description claims "existing retry/timeout behavior" is preserved. Now a single transient TimeoutException immediately triggers the outer loop's recovery path, which quits the driver and recreates all resources from scratch—far more expensive than the previous in-place retry with backoff. The new upload_vumark_template call also lacks any retry logic.


Updates the secrets generation flow to obtain VuMark target IDs via
vws_web_tools.upload_vumark_templateinstead of reading a shared target ID from environment variables.admin/create_secrets_files.pynow creates a temporary SVG template, uploads it, and writes the returnedVUMARK_VUFORIA_TARGET_IDto each generated secrets file with existing retry/timeout behavior.The change also bumps
vws-web-toolsto2026.2.17and documentsVUMARK_VUFORIA_TARGET_IDinvuforia_secrets.env.example.Note
Medium Risk
Changes the secrets-generation flow to create and upload a VuMark template via Selenium and persist the returned target ID; failures/timeouts or Vuforia UI changes could break CI/test setup. Dependency bump to
vws-web-toolsmay also subtly change automation behavior.Overview
Secrets generation now creates a VuMark template on the fly and derives
VUMARK_VUFORIA_TARGET_IDfrom Vuforia instead of relying on a pre-shared ID.admin/create_secrets_files.pyuploadsadmin/vumark_template.svgviavws_web_tools.upload_vumark_template, fetches the target ID, and writes it into each generated secrets file (with existing timeout/retry handling).Updates the example env file to include
VUMARK_VUFORIA_TARGET_ID, and bumpsvws-web-toolsto2026.2.17.1to support the new automation.Written by Cursor Bugbot for commit 206f379. This will update automatically on new commits. Configure here.