Merged
Conversation
Use get_database_details from vws-web-tools to fetch inactive database credentials instead of loading from an existing secrets file. This simplifies the setup by reducing env vars from 6 to 1 (INACTIVE_VUFORIA_TARGET_MANAGER_DATABASE_NAME). Removes python-dotenv dependency and simplifies admin/create_secrets_files.py. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
…ttern Take a driver parameter and let TimeoutException propagate, consistent with _create_and_get_database_details and the other helper functions. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps vws-web-tools from 2026.2.20 to 2026.2.22 and refactors admin/create_secrets_files.py to use the new
get_database_detailsfunction. Instead of loading inactive database credentials from an existing secrets file (requiring 5+ env vars), the script now fetches them dynamically using the web driver (requiring only the database name).python-dotenvdependencyEXISTING_SECRETS_FILE+ 5INACTIVE_*vars to justINACTIVE_VUFORIA_TARGET_MANAGER_DATABASE_NAME🤖 Generated with Claude Code
Note
Medium Risk
Moderate risk because it changes how test secrets are generated and adds an extra webdriver/login flow; failures would mainly impact local/CI setup rather than runtime behavior.
Overview
Updates
vws-web-toolsto2026.2.22and removes the dev dependency onpython-dotenv.Refactors
admin/create_secrets_files.pyto no longer load an “inactive” database’s access keys from an existing secrets file; it now takes onlyINACTIVE_VUFORIA_TARGET_MANAGER_DATABASE_NAMEand uses a separate webdriver login to fetch inactive database details viaget_database_details, then reuses those details when generating new secrets files.Documentation is updated to reflect the reduced environment-variable/setup requirements.
Written by Cursor Bugbot for commit 05bd0ea. This will update automatically on new commits. Configure here.