Add no-defaults linting - #3124
Merged
Merged
Conversation
adamtheturtle
temporarily deployed
to
development
August 5, 2026 17:22 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
marked this pull request as ready for review
August 5, 2026 18:30
adamtheturtle
temporarily deployed
to
development
August 5, 2026 22:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Picks up the fix for annotated locals in dataclass methods being misreported as fields (adamtheturtle/no-defaults#6). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Run no-defaults as a local uv hook instead of the upstream pre-commit hook, matching the other locally-defined hooks. The pin moves to the dev extra in pyproject.toml, and the hook joins the pre-commit.ci skip list alongside the other hooks that need project dependencies. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
adamtheturtle
force-pushed
the
agent/add-no-defaults-linter
branch
from
August 6, 2026 05:56
0c64e8f to
4c3d1eb
Compare
adamtheturtle
temporarily deployed
to
development
August 6, 2026 05:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
no-defaultsv1.0.0 to the pre-commit/prek configuration.The policy rejects defaults everywhere in
tests/**and for private functions, classes, and modules elsewhere. Existing defaults are behavior-preservingly baselined with targeted# noqa: NOD001comments where necessary; Ruff is configured to recognize the externalNODrule family. Vendored Typeshed is excluded where applicable.Validated with
prek validate-config,prek run no-defaults --all-files, and Ruff checks.Note
Low Risk
Tooling and lint configuration only; no runtime or API behavior changes.
Overview
Adds
no-defaults(v1.0.1) to dev dependencies and wires it into pre-commit as a serial Python hook (uv run --extra=dev no-defaults), alongside existing strict-kwargs-style checks.Configures policy in
[tool.no_defaults]:private_only = truefor production code (private functions/classes/modules) andper_file_enforcement."tests/**" = "all"so tests disallow defaults everywhere. Ruff is updated withlint.external = ["NOD"]so# noqa: NOD001suppressions are recognized when the linter runs.Reviewed by Cursor Bugbot for commit 4c3d1eb. Bugbot is set up for automated code reviews on this repo. Configure here.