Adjust glow_overlay ray trace position calculation#1785
Closed
lunairekitty wants to merge 1 commit intoValveSoftware:masterfrom
Closed
Adjust glow_overlay ray trace position calculation#1785lunairekitty wants to merge 1 commit intoValveSoftware:masterfrom
lunairekitty wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
Change the pos value form 0.999 to 0.99 to fix the issue of env_sun disappearing when directly under the crosshair, even when the crosshair sprite is not active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Change the pos value of glow_overlay.cpp from
Vector pos = CurrentViewOrigin() + m_vDirection * zFar * 0.999f;toVector pos = CurrentViewOrigin() + m_vDirection * zFar * 0.99f;.This fixes the issue of env_sun disappearing when directly under the crosshair, even when the crosshair sprite is not active.