fix: stop prompting basic analysts to call tools they lack - #184
Merged
Conversation
Shared WTI/BoC analyst instructions referenced search_web (and hard-required set_model_response) even for no-tool basic configs, which can yield silent empty turns in adk web when the model tries unavailable tools. Move search guidance into supplements appended only by news-capable factories, and soften SMR wording to the if-available / else plain-JSON pattern. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search_web(and hard-requiredset_model_response), which can produce silent empty turns inadk webwhen the model attempts unavailable tools.set_model_responseis available… otherwise return plain JSON,” matching the multitask prompt.Test plan
build_wti_basic_config().instruction/build_boc_basic_config().instructioncontain nosearch_webuv run adk web implementations/energy_oil_forecasting/analyst_agent— ask a search-like question on basic; expect a text reply (no silent blank turn from a missing-tool call)search_webbefore forecastingMade with Cursor