Conversation
|
This looks like a good fix to the p3 spec. But, I don't think this fully resolves #889, because we also need to add docs to the p2 spec as well. |
Ah good call, we should at least add docs to p2. I believe adding to the error variant in p2 would be a breaking change. We could introduce a new type error and mirror existing methods/funcs to fail with the new error type. What do you think? |
Opting for documenting two floors, one for individual fields and the other for aggregate. Exceeding either will fail with `header-error.size-exceeded`. Resolves #889
6b462c1 to
2675aa0
Compare
|
Required to get a passing CI. Guessing someone merged without them updated.
…On Thu, Feb 26, 2026, 4:52 PM Lann ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On proposals/cli/wit-0.3.0-draft/deps.lock
<#891 (comment)>:
Are these unrelated changes?
—
Reply to this email directly, view it on GitHub
<#891 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHN34Y7VBYBCHIYLON5JI34N5TJNAVCNFSM6AAAAACWA44XT6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQNRTG4ZTGNBWGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
If we want to be defensive about the 0.3.x target, we could also consider adding an additional I checked and we already have edit: went ahead and filed a standalone issue for this: #892 |
Defensively extend the variants for http, related to #892 I used option<string> to match error-code's internal-error(option<string>)
| /// string for an unstructured description of the error. Users should not | ||
| /// depend on the string for diagnosing errors, as it's not required to be | ||
| /// consistent between implementations. | ||
| other(option<string>), |
There was a problem hiding this comment.
I used other(option<string>) to match error-code's internal-error(option<string>)
I could argue for the description being required, but we should aim to keep these two consistent.
|
Looks good to me too w.r.t #892. |
Specific minimum sizes are intentionally left unspecified. Implementations operate in diverse environments with varying constraints, so limits are implementation-defined. Making operations fallible with size-exceeded is sufficient to ensure correct error handling without prescribing specific thresholds.
Opting for documenting two floors, one for individual fields and the other for aggregate.Exceeding implementation defined limits will fail with
header-error.size-exceeded.Specific minimum sizes are intentionally left unspecified. Implementations operate in diverse environments with varying constraints, so limits are implementation-defined.
Making operations fallible with size-exceeded is sufficient to ensure correct error handling without prescribing specific thresholds.
Part of #889