Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch lowers BrOn* into Br in Flatten, allowing it to flatten GC code. I
then tested to see if Flatten+ReReloop end up helping, which in theory they
could have since
(fewer nested effects).
However, I don't see a benefit. The benefits we saw on non-GC code, that
is LLVM output, may have been tied to LLVM. In particular LLVM doesn't
emit Ifs, but GC compilers do. (I tested on Kotlin and Java.)
This is not worth landing but I wanted to post it, as evidence that we don't
need to work on Flatten currently. Maybe we can even consider removing it
entirely.