Skip to content

[Fuzzer] Make Split's exports a list of strings#8731

Merged
aheejin merged 5 commits into
WebAssembly:mainfrom
aheejin:wasm_split_fuzz_fix2
May 21, 2026
Merged

[Fuzzer] Make Split's exports a list of strings#8731
aheejin merged 5 commits into
WebAssembly:mainfrom
aheejin:wasm_split_fuzz_fix2

Conversation

@aheejin
Copy link
Copy Markdown
Member

@aheejin aheejin commented May 20, 2026

When the export name contains a comma, such as foo<x,y>, the v8 command does not work:

v8 ... exports:foo<x,y>,bar,... --fuzz-split

This generates an exports as a list of strings within quotes, supporting export names with commas:

v8 ... exports:["foo<x,y>","bar",...] --fuzz-split

This still parses the old format of exports in case it doesn't contain commas, which I think might be useful for handwritten command lines.

When the export name contains a comma, such as `foo<x,y>`, the v8
command does not work:
```colsole
v8 ... exports:foo<x,y>,foo,bar,... --fuzz-split
```

This generates an `exports` as a list of strings within quotes,
supporting export names with commas.

This still parses the old format of `exports` in case it doesn't contain
commas, which I think might be useful for handwritten command lines.
@aheejin aheejin requested a review from kripken May 20, 2026 05:18
@aheejin aheejin requested a review from a team as a code owner May 20, 2026 05:18
@aheejin
Copy link
Copy Markdown
Member Author

aheejin commented May 20, 2026

@kripken
Copy link
Copy Markdown
Member

kripken commented May 20, 2026

The log says KeyboardInterrupt 😄 - who is clicking control-c in CI?

Does restarting the job help?

@aheejin
Copy link
Copy Markdown
Member Author

aheejin commented May 20, 2026

Ah, maybe that was me. It took forever in the first try so I reran only that job in the CI panel but it also took forever so I merged main and made a new commit (so by adding a new commit the previous job was interrupted maybe) but the Window check is taking forever on this commit still. I wonder what in this PR can hang Windows..........

@aheejin
Copy link
Copy Markdown
Member Author

aheejin commented May 21, 2026

I'll revert all changes in this PR just to make sure if my change is causing the issue.

@aheejin
Copy link
Copy Markdown
Member Author

aheejin commented May 21, 2026

Not all checks are finished but the Windows-11-arm is done already: https://github.com/WebAssembly/binaryen/actions/runs/26197299501/job/77079404504?pr=8731

So this change causes Windows-11-arm (but not Windows-latest) to hang.... Why....

@stevenfontanella
Copy link
Copy Markdown
Member

stevenfontanella commented May 21, 2026

This windows run is also taking a while, so maybe there's some infra issue? https://github.com/WebAssembly/binaryen/actions/runs/26190799279/job/77058425164?pr=8625

@aheejin
Copy link
Copy Markdown
Member Author

aheejin commented May 21, 2026

OK apparently other PRs have this Windows CI problem too: #8742, #8625, and #8743

@kripken
Copy link
Copy Markdown
Member

kripken commented May 21, 2026

Maybe this which just landed helps? #8749

@aheejin aheejin merged commit 1215ea4 into WebAssembly:main May 21, 2026
16 checks passed
@aheejin aheejin deleted the wasm_split_fuzz_fix2 branch May 21, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants