Skip to content

Fix test_cluster_fuzz.py V8 flags mismatch #8746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlively merged 1 commit into from
May 21, 2026
+6 −3
Merged

Fix test_cluster_fuzz.py V8 flags mismatch #8746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions test/unit/test_cluster_fuzz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,11 +435,14 @@ def test_file_contents(self):
valid_executions = 0
for i in range(1, N + 1):
fuzz_file = os.path.join(temp_dir.name, f'fuzz-binaryen-{i}.js')
flags_file = os.path.join(temp_dir.name, f'flags-binaryen-{i}.js')

# Read flags from flags file to faithfully simulate how
# ClusterFuzz runs V8.
with open(flags_file) as f:
flags = f.read().strip().split()
# Add --fuzzing to allow legacy and standard EH to coexist
cmd = [shared.V8,
'--wasm-staging',
'--experimental-wasm-custom-descriptors',
cmd = [shared.V8] + flags + [
'--fuzzing',
fuzz_file]
# Capture stderr even though we will not read it. It may
Expand Down
Loading