Skip to content

Conversation

@priethor
Copy link
Contributor

@priethor priethor commented Dec 5, 2025

What

Fixes a bug in the menu_icon property that came up while adding Options Pages abilities in #273, as it had the wrong type.

@priethor priethor self-assigned this Dec 5, 2025
@priethor priethor added the [Type] Bug Something isn't working label Dec 5, 2025
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.98%. Comparing base (34a448e) to head (192d758).
⚠️ Report is 2 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk     #274      +/-   ##
============================================
- Coverage     10.98%   10.98%   -0.01%     
  Complexity     4288     4288              
============================================
  Files           266      266              
  Lines         33159    33159              
============================================
- Hits           3644     3642       -2     
- Misses        29515    29517       +2     
Flag Coverage Δ
e2e 29.55% <ø> (-0.03%) ⬇️
phpunit 6.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@priethor priethor marked this pull request as ready for review December 10, 2025 10:17
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props priethor.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@priethor priethor added this to the 6.7.1 milestone Dec 10, 2025
@priethor priethor merged commit 4cd4600 into trunk Dec 10, 2025
10 checks passed
@priethor priethor deleted the fix/options-pages-schema-menu_icon branch December 10, 2025 10:45
@cbravobernal cbravobernal modified the milestones: 6.7.1, 6.7.2 Dec 10, 2025
@cbravobernal
Copy link
Contributor

I'm afraid this didn't make it to 6.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants