Conversation
3343667 to
536ee49
Compare
536ee49 to
6d98b54
Compare
Merged
adamziel
approved these changes
Dec 18, 2025
Collaborator
adamziel
left a comment
There was a problem hiding this comment.
reviewing this commit by commit it seems like a fairly small PR despite what the files changed tab says. Looking good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracting smaller chunks from #291 so we can review and merge them independently.
This PR renames the current
WP_SQLite_DrivertoWP_PDO_MySQL_On_SQLiteand reintroduces theWP_SQLite_Driveras a simple proxy over the new renamed class. It's done in these two steps (first rename, then reintroduce) so that Git understands the rename and presents history (hopefully) accurately.The changes are better understood in a commit-by-commit view.
WP_PDO_MySQL_On_SQLitevsWP_SQLite_DriverThe "reintroduced"
WP_SQLite_Driveris not meant to be permanent. It is a temporary proxy so we can gradually modifyWP_PDO_MySQL_On_SQLiteto support PDO APIs while not touching the driver API just yet. Once the basics of PDO API are in place, we can make all dependencies use the new class directly and then remove theWP_SQLite_Driver.That is, in the future, the
WP_SQLite_DB extends wpdbwill use directly the newWP_PDO_MySQL_On_SQLiteclass.