-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix : Prevent viewScriptModule enqueue on admin for blocks #10693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Fix : Prevent viewScriptModule enqueue on admin for blocks #10693
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| } | ||
|
|
||
| if ( ! empty( $this->block_type->view_script_module_ids ) ) { | ||
| if ( ! empty( $this->block_type->view_script_module_ids ) && ! is_admin() ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This extra condition differs from the view_script_handles block above. I'd like to understand why the behavior is different and requires this change for modules but not for scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, wouldn't it also be applicable for view_script_handles? I'm guessing those scripts are also being erroneously enqueued in the block editor currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really needs some debugging and an explanation. I don't think this change should move ahead until there's an understanding of why these systems behave differently.
It's possible that there another issue going on, perhaps an issue with scripts, or it may be that this change should also be applied to scripts.
wp_enqueue_script_moduleTrac ticket: https://core.trac.wordpress.org/ticket/64484
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.