Bump PHPStan rule level to 1 by westonruter · Pull Request #11151 · WordPress/wordpress-develop

westonruter · 2026-03-04T02:14:53Z

By increasing the PHPStan rule level to 1, the following issues will begin to be detected for new code introduced to core:

possibly undefined variables, unknown magic methods and properties on classes with __call and __get

Here is the original tally of ignored errors in tests/phpstan/baseline.php categorized by their PHPStan identifier:

Identifier	Description	Error Count
`empty.variable`	Using `empty()` on variables that always exist, are always falsy, or are not falsy	9
`constant.notFound`	Usage of constants that are not found or defined in the analyzed scope	9
`isset.variable`	Using `isset()` on variables that always exist, are not nullable, or are never defined	5
`variable.undefined`	Accessing variables that are never defined or are possibly undefined	4
`arguments.count`	Functions or methods invoked with more parameters than they actually require	4
`constructor.unusedParameter`	Class constructors that have parameters that are never used	1
Total		32

And with the current fixes pushed to this branch, these are the remaining errors in the baseline:

Identifier	Description	Error Count
`empty.variable`	Using `empty()` on variables that always exist, are always falsy, or are not falsy	8
`isset.variable`	Using `isset()` on variables that always exist, are not nullable, or are never defined	4
Total		12

This cherry-picks some commits from #11009.

Use of AI Tools

n/a

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…berg build

Co-authored-by: Dovid Levine <david@axepress.dev>

github-actions · 2026-03-04T02:15:02Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props westonruter, apermo.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2026-03-04T02:22:06Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

PHPStan cannot verify that wp_die() always terminates due to its conditional return type and treatPhpDocTypesAsCertain being disabled.

Co-authored-by: Christoph Daum <christoph.daum@coding-pioneers.com>

Co-authored-by: Weston Ruter <westonruter@gmail.com>

phpstan.neon.dist

…into bump/phpstan-level-1

Fixes PHPStan issue: ------ --------------------------------------------------------------- Line wp-admin/includes/class-wp-posts-list-table.php ------ --------------------------------------------------------------- 357 Variable $class in empty() always exists and is always falsy. 🪪 empty.variable at src/wp-admin/includes/class-wp-posts-list-table.php:357 ------ ---------------------------------------------------------------

…edit_link() takes no args

westonruter · 2026-03-06T20:57:11Z

src/wp-includes/cache-compat.php

@JJJ Do these changes (a47a434) look good to you? PHPStan flagged some issues, in that method_exists() doesn't guarantee the first arg is an object. Also, it was passing $blog_id to wp_cache_switch_to_blog_fallback() which doesn't take an arg.

Ref. r61760 (530fe2e) for Core-23290.

westonruter · 2026-03-06T20:59:51Z

src/wp-content/themes/twentyseventeen/template-parts/page/content-front-page-panels.php

 			<header class="entry-header">
 				<?php the_title( '<h2 class="entry-title">', '</h2>' ); ?>

-				<?php twentyseventeen_edit_link( get_the_ID() ); ?>


@sabernhardt Given that twentyseventeen_edit_link() is a pluggable function, would you feel better to add the new parameter? Or should the param be removed from being passed since it isn't used?

I'd like to discuss twentyseventeen_edit_link() in a separate ticket.

I wondered why the function did not have a parameter and then found out it had an $id parameter in the initial commit. But then the page/post context was removed, and the parameter was removed before the function was ever pluggable (and before version 1.0). Also, the comment about context does not seem appropriate.

@sabernhardt I've opened Core-64825 for this.

…into bump/phpstan-level-1

…venteen_edit_link() takes no args" This reverts commit 680d165.

westonruter and others added 5 commits March 3, 2026 18:02

Ignore errors in src/wp-includes/build which currently come the Guten…

6d83596

…berg build

Bump phpstan to 2.1.40

5dec036

Bump PHPStan to level 1

593a10c

Ignore variable.undefined errors since too noisy

22de4b6

Co-authored-by: Dovid Levine <david@axepress.dev>

Regenerate baseline for level 1

cb8db15

westonruter and others added 2 commits March 3, 2026 19:08

Remove unused parameter for WP_Filesystem_Direct constructor

d3dd8ec

Add theme constants to config to address constant.notFound errors

bf92684

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

westonruter force-pushed the bump/phpstan-level-1 branch from e6bd045 to bf92684 Compare March 4, 2026 03:20

apermo and others added 7 commits March 3, 2026 19:24

Docs: Add @return never to dead_db().

d39600a

fix(phpstan): Ignore return.never on dead_db()

75797b7

PHPStan cannot verify that wp_die() always terminates due to its conditional return type and treatPhpDocTypesAsCertain being disabled.

Fix phpstan-return syntax

e55878c

Co-authored-by: Christoph Daum <christoph.daum@coding-pioneers.com>

Remove now-unnecessary phpstan-ignore

46b656a

docs: Refine phpdoc of dead_db()

3c46095

Co-authored-by: Weston Ruter <westonruter@gmail.com>

Remove never from check_connection return

c52438a

Remove errors from baseline which were fixed by never returns

87a2c04

westonruter mentioned this pull request Mar 4, 2026

Docs: Replace void with null in union return types in class-wpdb.php #11009

Open

Resolve isset.variable error since $_POST global is always set

95ddce2

westonruter marked this pull request as draft March 4, 2026 03:38

westonruter commented Mar 5, 2026

View reviewed changes

phpstan.neon.dist Outdated Show resolved Hide resolved

Merge branch 'trunk' of https://github.com/WordPress/wordpress-develop …

5e62661

…into bump/phpstan-level-1

westonruter mentioned this pull request Mar 6, 2026

Fix PHPStan undefined variable errors at level 3 #11189

Open

westonruter added 5 commits March 6, 2026 11:43

Use allow-list for unknown globals

2d77448

Convert single variable.undefined ignore rule into one per variable

eeefc04

Fix wp_cache_switch_to_blog() issues

a47a434

Fix arguments.count issues in Twenty Seventeen where twentyseventeen_…

680d165

…edit_link() takes no args

westonruter commented Mar 6, 2026

View reviewed changes

westonruter mentioned this pull request Mar 6, 2026

Introduce WP_List_Table::get_views_links(). #2828

Closed

westonruter added 5 commits March 6, 2026 18:03

Merge branch 'trunk' of https://github.com/WordPress/wordpress-develop …

53208cc

…into bump/phpstan-level-1

Remove $comment_id variable.undefined error after r61859 (ce40cd3)

a088867

Remove $shape from being a variable.undefined ignored error

202c39c

Revert "Fix arguments.count issues in Twenty Seventeen where twentyse…

de684c6

…venteen_edit_link() takes no args" This reverts commit 680d165.

Initialize $shape variable to suppress variable.undefined error

db38dbf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump PHPStan rule level to 1#11151

Bump PHPStan rule level to 1#11151
westonruter wants to merge 26 commits intoWordPress:trunkfrom
westonruter:bump/phpstan-level-1

westonruter commented Mar 4, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

Uh oh!

westonruter Mar 6, 2026

Uh oh!

westonruter Mar 6, 2026

Uh oh!

sabernhardt Mar 7, 2026

Uh oh!

westonruter Mar 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

westonruter commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Use of AI Tools

Uh oh!

github-actions bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 4, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

Uh oh!

westonruter Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

westonruter Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

sabernhardt Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

westonruter Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

westonruter commented Mar 4, 2026 •

edited

Loading

github-actions bot commented Mar 4, 2026 •

edited

Loading