Login and Registration: Fix spacing in admin email confirmation buttons#11172
Login and Registration: Fix spacing in admin email confirmation buttons#11172sanketio wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
How to test locally
|
| .login .admin-email-confirm-form .submit { | ||
| text-align: center; | ||
| } |
There was a problem hiding this comment.
It was added in https://core.trac.wordpress.org/changeset/45757 but admin-email-confirm-form form didn't use the submit class since it was implemented
There was a problem hiding this comment.
So should I keep it, or is it fine to remove it?
Fixes a spacing issue in the administration email verification screen.
The
.admin-email__actions divselector was too broad and provided no wrapping behaviour for the action buttons. On locales with longer button text (e.g. fr_FR), the "Update" and "The email is correct" buttons lost proper spacing.Additionally, two CSS rules —
.login .admin-email-confirm-form .submitand.admin-email__later— were targeting class names that no longer exist in the HTML markup and have been removed.Changes:
.admin-email__actions div { padding-top }with targeted.admin-email__actions-primaryrule usingdisplay: flex,flex-wrap: wrap, andgap: 0.5emso buttons wrap gracefully on any locale..admin-email__actions-secondaryrule with a reducedpadding-topfor the "Remind me later" link row.margin-left/margin-rightfrom.login .admin-email__actions .button-primary— spacing is now handled by flexgapon the container..login .admin-email-confirm-form .submitand.admin-email__laterrules.Trac ticket: https://core.trac.wordpress.org/ticket/64774
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.