Skip to content

Login and Registration: Fix spacing in admin email confirmation buttons#11172

Open
sanketio wants to merge 2 commits intoWordPress:trunkfrom
sanketio:fix/64774
Open

Login and Registration: Fix spacing in admin email confirmation buttons#11172
sanketio wants to merge 2 commits intoWordPress:trunkfrom
sanketio:fix/64774

Conversation

@sanketio
Copy link

@sanketio sanketio commented Mar 5, 2026

Fixes a spacing issue in the administration email verification screen.

The .admin-email__actions div selector was too broad and provided no wrapping behaviour for the action buttons. On locales with longer button text (e.g. fr_FR), the "Update" and "The email is correct" buttons lost proper spacing.

Additionally, two CSS rules — .login .admin-email-confirm-form .submit and .admin-email__later — were targeting class names that no longer exist in the HTML markup and have been removed.

Changes:

  • Replace .admin-email__actions div { padding-top } with targeted .admin-email__actions-primary rule using display: flex, flex-wrap: wrap, and gap: 0.5em so buttons wrap gracefully on any locale.
  • Add .admin-email__actions-secondary rule with a reduced padding-top for the "Remind me later" link row.
  • Remove orphaned margin-left/margin-right from .login .admin-email__actions .button-primary — spacing is now handled by flex gap on the container.
  • Remove dead .login .admin-email-confirm-form .submit and .admin-email__later rules.

Trac ticket: https://core.trac.wordpress.org/ticket/64774

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sanketparmar, mukesh27, valentingrenier.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@valentin-grenier
Copy link

How to test locally

  1. Launch a local WordPress instance on your machine
  2. Go to /wp-admin/options.php page
  3. Search for admin_email_lifespan (CTRL/cmd + f)
  4. Replace the timestamp with a future one — you can easily generate a timestamp here
  5. Open a terminal with WP-CLI support
  6. Run those two commands: wp transient delete --all and wp cache flush
  7. Log out and wait for the timestamp to become expired
  8. Log in again — you should be able to reach the admin email confirmation page
  9. Check for the patch

Comment on lines -224 to -226
.login .admin-email-confirm-form .submit {
text-align: center;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added in https://core.trac.wordpress.org/changeset/45757 but admin-email-confirm-form form didn't use the submit class since it was implemented

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should I keep it, or is it fine to remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants