Skip to content

Emoji: Print the emoji detection script in the admin footer. #11905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sirreal wants to merge 1 commit into
base: trunk
Choose a base branch
from
+26 −2
Open

Emoji: Print the emoji detection script in the admin footer. #11905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-admin/edit-form-blocks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ static function ( $classes ) {
/*
* Emoji replacement is disabled for now, until it plays nicely with React.
*/
remove_action( 'admin_print_scripts', 'print_emoji_detection_script' );
remove_action( 'admin_print_footer_scripts', 'print_emoji_detection_script' );

/*
* Block editor implements its own Options menu for toggling Document Panels.
Expand Down
2 changes: 1 addition & 1 deletion src/wp-admin/includes/admin-filters.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
add_action( 'admin_print_styles', 'wp_resource_hints', 1 );
}

add_action( 'admin_print_scripts', 'print_emoji_detection_script' );
add_action( 'admin_print_footer_scripts', 'print_emoji_detection_script' );
Copy link
Copy Markdown
Member

@westonruter westonruter May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only concern I have about this is back-compat for sites which gave sought to disable emoji. Thus change would cause emoji to show up again in the admin for them, no?

Copy link
Copy Markdown
Member Author

@sirreal sirreal May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Do you have ideas about how this can be done in a backwards compatible way? Would maintain the function on the same action, but have it enqueue another admin_print_footer_scripts action? Something like this:

  function print_emoji_detection_script() {
      if ( doing_action( 'admin_print_scripts' ) ) {
          add_action( 'admin_print_footer_scripts', 'print_emoji_detection_script' );
          return;
      }
      // print the script module
  }

Copy link
Copy Markdown
Member

@westonruter westonruter May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just found a bug with how print_emoji_detection_script() was changed in 6.9. I've opened Core-65310 to address this. It means that the emoji detection script isn't actually being printed in the admin directly at all right now.

My original suggestion to implement this change was invalid.

For additional feedback, see comment on Trac.

add_action( 'admin_print_scripts', 'print_head_scripts', 20 );
add_action( 'admin_print_footer_scripts', '_wp_footer_scripts' );
add_action( 'admin_enqueue_scripts', 'wp_enqueue_emoji_styles' );
Expand Down
24 changes: 24 additions & 0 deletions tests/phpunit/tests/formatting/emoji.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,4 +216,28 @@ public function data_wp_staticize_emoji() {
public function test_wp_staticize_emoji( $emoji, $expected ) {
$this->assertSame( $expected, wp_staticize_emoji( $emoji ) );
}

/**
* The emoji detection script outputs a `<script type="module">`. In the admin it must
* be printed in the footer (after the script-module import map) rather than the head,
* otherwise the import map is encountered after a module script and is treated as
* inert by browsers that follow the spec strictly (e.g. Firefox).
*
* @ticket 65260
*
* @covers ::print_emoji_detection_script
*/
public function test_print_emoji_detection_script_is_hooked_to_admin_footer() {
require_once ABSPATH . 'wp-admin/includes/admin-filters.php';

$this->assertFalse(
has_action( 'admin_print_scripts', 'print_emoji_detection_script' ),
'print_emoji_detection_script must not run on admin_print_scripts; the resulting <script type="module"> would precede the import map.'
);
$this->assertSame(
10,
has_action( 'admin_print_footer_scripts', 'print_emoji_detection_script' ),
'print_emoji_detection_script must run on admin_print_footer_scripts, after the import map.'
);
}
}
Loading