Update get_metadata_by_mid() to return null instead of false when metadata is missing#11919
Update get_metadata_by_mid() to return null instead of false when metadata is missing#11919arifrahmanbb wants to merge 3 commits into
Conversation
|
Hi @arifrahmanbb! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Description
This PR addresses Trac ticket #64986 by updating the
Youtube_by_mid()function inwp-includes/meta.phpto returnnullinstead offalsewhen validation fails or a metadata row is not found.Currently, the function's DocBlock documentation specifies
@return stdClass|null, but the actual implementation incorrectly returnsfalsein early return statements and when the database query comes up empty. This change ensures that the function's behavior perfectly aligns with its documented return type and matches expected core standard behavior.Trac Ticket
Trac ticket: https://core.trac.wordpress.org/ticket/64986
Use of AI Tools
AI assistance: No