Translate: Remove the unused ajax-fetch-openai-review.php endpoint - #752
Closed
ocean90 wants to merge 1 commit into
Closed
Translate: Remove the unused ajax-fetch-openai-review.php endpoint#752ocean90 wants to merge 1 commit into
ocean90 wants to merge 1 commit into
Conversation
This standalone endpoint is not referenced by any code. The editor's OpenAI auto-review was switched to a direct streaming request in gp-translation-helpers, and OpenAI suggestions are served by the `-get-tm-openai-suggestions` route, leaving this file as dead code.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wporg-gp-translation-suggestions/ajax-fetch-openai-review.phpis a standalone,directly-requestable endpoint that is not referenced by any code.
It was added in 5e89dcf (2023-06-06) as a "slim admin-ajax" variant for
fetching a ChatGPT review and last touched in 221eb5c (2024-06-17), but nothing
ever wired to it:
gp-translation-helpers (Switch Auto-Review to use the OpenAI Streaming API directly GlotPress/gp-translation-helpers#172), and
-get-tm-openai-suggestionsGlotPressroute (
Routes\Translation_Memory::get_openai_suggestions()), added earlier inc546319 (2023-04-05).
The file has been unreferenced since it landed, so this removes dead code. No
functional change.