This repository was archived by the owner on Jul 3, 2020. It is now read-only.
Update ControllerPermissionsGuard add condition check#359
Open
Itach1Uchixa wants to merge 1 commit intoZF-Commons:masterfrom
Itach1Uchixa:master
Open
Update ControllerPermissionsGuard add condition check#359Itach1Uchixa wants to merge 1 commit intoZF-Commons:masterfrom Itach1Uchixa:master
Itach1Uchixa wants to merge 1 commit intoZF-Commons:masterfrom
Itach1Uchixa:master
Conversation
1 similar comment
Collaborator
|
Coverage decreased, some more tests? |
Author
|
I don't understand what causes this error, I think it's because I added some new unit tests. Help me! |
Collaborator
|
The reason you get an error is because you've added code... so on average the score when drown |
Author
|
As I understand it is not a error or big problem, right? |
Collaborator
|
Correct it is not an error, nor a 'big' problem. However, we kindly request tests are written for all code that is added. edit: You can run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ControllerPermissionsGuard add condition check