Refactor gem and make nuget hashable#75
Merged
TG1999 merged 2 commits intoaboutcode-org:mainfrom Apr 11, 2023
Merged
Conversation
Member
keshav-space
commented
Jun 21, 2022
keshav-space
commented
- Refactor GemVersion
- Make NuGet version hashable
- Moved from Fix constraints duplication #69
pombredanne
requested changes
Jul 26, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks... See my review comments. Please keep segments and canonical_segments as tuples, e.g. the new property should return a tuple() not a generator.
keshav-space
force-pushed
the
refactor_gem
branch
from
c2b0344 to
3c2dd92
Compare
Signed-off-by: Keshav Priyadarshi <[email protected]>
Signed-off-by: Keshav Priyadarshi <[email protected]>
keshav-space
force-pushed
the
refactor_gem
branch
from
3c2dd92 to
19de006
Compare
keshav-space
pushed a commit
that referenced
this pull request
Aug 30, 2023
Update the following actions: * actions/checkout * actions/setup-python Reference: aboutcode-org/skeleton#75 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
keshav-space
pushed a commit
that referenced
this pull request
Aug 30, 2023
Bump github actions versions #75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.