Fix left justified implementation on I2SIn with external clock - #11170
Merged
Conversation
relic-se
marked this pull request as ready for review
August 3, 2026 18:14
FoamyGuy
approved these changes
Aug 4, 2026
FoamyGuy
left a comment
FoamyGuy
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix!
This change is correct, I got it swapped around during development. I tested this branch successfully on the EP-2350.
I will submit follow up PRs in the driver and guide project code to account for this change.
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newly merged I2SIn bidirectional support implements left justified operation incorrectly when it is acting as a secondary device (
external_clock=True). This update fixes that by inverting the logic in the PIO generation method so that normal operation occurs one clock cycle offset from the word clock and left justified occurs immediately when the word clock changes.