feat: Add Scatter to the S2 package (pre-alpha) - #869
Open
tanugarg04 wants to merge 2 commits into
Open
Conversation
|
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-869 🎨 S2 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-869-s2 📚 Docs -> https://opensource.adobe.com/react-spectrum-charts/PR-869-docs/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Add Scatter to the S2 package (pre-alpha)
Description
Ports
Scatterinto@spectrum-charts/react-spectrum-charts-s2as a pre-alphacomponent — full prop support, plus its child components
ScatterPath,ScatterAnnotation,Trendline, andTrendlineAnnotation. Also renames thepackage's
rcexport tier topre-alpha(./rc→./pre-alpha) and fixes twopre-existing bugs uncovered along the way.
The underlying
vega-spec-builder-s2spec-generation logic for all of thesealready existed and needed no changes — this PR is entirely the React
component/adapter layer plus build/docs wiring.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: