Add properties relating Vec.lookup to head and tail#3004
Open
Taneb wants to merge 6 commits into
Open
Conversation
jamesmckinna
approved these changes
Jun 9, 2026
jamesmckinna
left a comment
jamesmckinna
left a comment
Collaborator
There was a problem hiding this comment.
Happy enough with things as they are here, but with some questions to at least consider.
Also: CHANGELOG
Member
Author
|
I'm holding off adding a changelog for this and my other PRs until after 2.4 is released |
Collaborator
Yeah, but this is such low-hanging fruit that it could easily be a v2.4 contribution? |
Collaborator
|
We've already made a release candidate for v2.4 and I'm very reluctant to add anything else to it. |
Collaborator
|
A couple of additional comments on |
JacquesCarette
requested changes
Jun 11, 2026
gallais
approved these changes
Jun 15, 2026
Collaborator
|
This all looks good to me now, so I'll enable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really surprised these didn't already exist!