Skip to content

Support for device code auth#248

Open
anvilpete wants to merge 2 commits into
agentclientprotocol:mainfrom
anvilpete:device-code-auth
Open

Support for device code auth#248
anvilpete wants to merge 2 commits into
agentclientprotocol:mainfrom
anvilpete:device-code-auth

Conversation

@anvilpete

@anvilpete anvilpete commented Jun 26, 2026

Copy link
Copy Markdown

This PR adds device code auth support for ChatGPT login when no browser is available. It is a re-implementation of zed-industries/codex-acp#291 for agentclientprotocol/codex-acp.

-> AuthenticateRequest
<- CreateElicitationRequest (url mode, request scope)
-> CreateElicitationResponse (accept)
<- AuthenticateResponse

An elicitation/complete isn't required, due to the AuthenticateResponse sent when authentication is complete (or an error if it failed).

anvilpete
anvilpete commented Jun 26, 2026
View reviewed changes
Comment thread src/CodexAcpClient.ts Outdated
mode: "url",
// This should be the authenticate requestId, but this is not exposed by the ACP SDK.
// The elicitation still works, but won't be tied to the authenticate request.
requestId: null,

@anvilpete anvilpete Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can fill in the requestId here without support to expose it from the ACP SDK.

I think this is fine for now, but could we consider adding requestId to the AgentHandlerContext?

@benbrandt benbrandt Jun 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I think I missed that. Will see if I can add quickly

@benbrandt benbrandt Jun 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agentclientprotocol/typescript-sdk#202

@anvilpete anvilpete Jun 29, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that, I've bumped to the latest SDK and wired up requestId.

It touched a lot of things, since several operations attempt to auto-authenticate, so they all needed the requestId to be passed through..

@anvilpete anvilpete requested a review from benbrandt June 29, 2026 18:32
@anvilpete

anvilpete commented Jul 13, 2026

Copy link
Copy Markdown
Author

@benbrandt Is there anything more you'd like to see before reviewing this? I've just rebased it onto the recent elicitation work, and I think it fits in pretty well. It's now also using your new requestId context field.

Happy to make any tweaks, it would be great to get this device code auth support merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benbrandt benbrandt Awaiting requested review from benbrandt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anvilpete @benbrandt