fix(embedding): make dimensions parameter optional in OpenAITextEmbed…#1437
Closed
BlueStar0821 wants to merge 1 commit into
Closed
fix(embedding): make dimensions parameter optional in OpenAITextEmbed…#1437BlueStar0821 wants to merge 1 commit into
BlueStar0821 wants to merge 1 commit into
Conversation
…ding The dimensions parameter was mandatory, preventing non-OpenAI embedding models from working through OpenAITextEmbedding. Making it optional allows third-party providers to use the model's default dimensions. Fixes agentscope-ai#1095 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ding
The dimensions parameter was mandatory, preventing non-OpenAI embedding models from working through OpenAITextEmbedding. Making it optional allows third-party providers to use the model's default dimensions.
Fixes #1095
AgentScope-Java Version
[The version of AgentScope-Java you are working on, e.g. 1.0.12, check your pom.xml dependency version or run
mvn dependency:tree | grep agentscope-parent:pom(only mac/linux)]Description
[Please describe the background, purpose, changes made, and how to test this PR]
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)