Skip to content

Refactor/chart view#38

Open
zChanges wants to merge 4 commits intomainfrom
refactor/chart-view
Open

Refactor/chart view#38
zChanges wants to merge 4 commits intomainfrom
refactor/chart-view

Conversation

@zChanges
Copy link
Copy Markdown
Collaborator

@zChanges zChanges commented Dec 12, 2022

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 12, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7c1e833

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zChanges zChanges force-pushed the refactor/chart-view branch from dcdbae4 to bd9bd3c Compare December 12, 2022 08:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 12, 2022 •
edited
Loading

Deploy preview for alauda-chart ready!

✅ Preview
https://alauda-chart-8z55fnovl-jounqin.vercel.app

Built with commit 64b2530.
This pull request is being automatically deployed with vercel-action

@zChanges zChanges force-pushed the refactor/chart-view branch 3 times, most recently from 12d64d9 to 31b683e Compare December 13, 2022 06:02
@zChanges zChanges force-pushed the refactor/chart-view branch from d5abc6d to 07ec46f Compare January 30, 2023 02:27
@JounQin JounQin changed the base branch from next to main December 8, 2023 06:34
@zChanges zChanges force-pushed the refactor/chart-view branch from 8ebf801 to 432d287 Compare December 8, 2023 06:34
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 8, 2023
View reviewed changes
src/components/uplot-lib/grouped-bars.ts
if (seriesIdx === 1) {
hRect = null;

const cx = u.cursor.left * pxRatio;

Check warning

Code scanning / CodeQL

Implicit operand conversion

This expression will be implicitly converted from undefined to number.
src/components/uplot-lib/grouped-bars.ts
hRect = null;

const cx = u.cursor.left * pxRatio;
const cy = u.cursor.top * pxRatio;

Check warning

Code scanning / CodeQL

Implicit operand conversion

This expression will be implicitly converted from undefined to number.
src/components/scale.ts Outdated
auto: notAuto,
range: (_u: uPlot, dataMin: number, dataMax: number) => {
const minV = min
? Math.max(dataMin, min || 0)

Check warning

Code scanning / CodeQL

Useless conditional

This use of variable 'min' always evaluates to true.
src/components/scale.ts Outdated
range: (_u: uPlot, dataMin: number, dataMax: number) => {
const minV = min
? Math.max(dataMin, min || 0)
: Math.min(dataMin, min || 0);

Check warning

Code scanning / CodeQL

Useless conditional

This use of variable 'min' always evaluates to false.
src/components/tooltip.ts
if (!titleFormatter) {
this.title.text(context.title as string);
return;
let tpl: string = title || NOT_AVAILABLE;

Check warning

Code scanning / CodeQL

Useless conditional

This use of variable 'title' always evaluates to true.
JounQin
JounQin reviewed Dec 8, 2023
View reviewed changes
.gitignore Outdated
.vercel
.*cache
*.tsbuildinfo
.git No newline at end of file
Copy link
Copy Markdown
Member

@JounQin JounQin Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

JounQin
JounQin reviewed Dec 8, 2023
View reviewed changes
.stylelintignore Outdated
*.sh
*.tsbuildinfo
*.lock
docs No newline at end of file
Copy link
Copy Markdown
Member

@JounQin JounQin Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

JounQin
JounQin reviewed Dec 8, 2023
View reviewed changes
.stylelintrc Outdated
]
}
]
"selector-type-no-unknown": null,
Copy link
Copy Markdown
Member

@JounQin JounQin Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@zChanges zChanges force-pushed the refactor/chart-view branch from 432d287 to 64b2530 Compare December 8, 2023 06:41
JounQin
JounQin requested changes Dec 8, 2023
View reviewed changes
.eslintrc.json
"extends": "@1stg/eslint-config/loose",
"rules": {
"regexp/strict": "off"
"regexp/strict": "off",
Copy link
Copy Markdown
Member

@JounQin JounQin Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

docs/reactive.md
# reactive

> 为了支持配置式 options 更新，图表动态响应更新
> reactive 由 on-change 库完成
Copy link
Copy Markdown
Member

@JounQin JounQin Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

底层换成 @vue/reactivity

package.json
},
"dependencies": {
"aphrodite": "^2.4.0",
"on-change": "^4.0.2",
Copy link
Copy Markdown
Member

@JounQin JounQin Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

换成 @vue/reactivity

package.json Outdated
"strict": true,
"update": true
"update": true,
"ignoreFiles": [
Copy link
Copy Markdown
Member

@JounQin JounQin Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@JounQin
Copy link
Copy Markdown
Member

JounQin commented Dec 8, 2023

本地先把 lint 修复完再提交

JounQin
JounQin reviewed Dec 8, 2023
View reviewed changes
package.json
}
},
"dependencies": {
"aphrodite": "^2.4.0",
Copy link
Copy Markdown
Member

@JounQin JounQin Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥用这个？我看都不维护了，建议用纯 scss 就行了

JounQin
JounQin reviewed Dec 8, 2023
View reviewed changes
package.json
"dependencies": {
"aphrodite": "^2.4.0",
"on-change": "^4.0.2",
"placement.js": "^1.0.0-beta.5",
Copy link
Copy Markdown
Member

@JounQin JounQin Dec 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个也过时了，不要用，试试 https://popper.js.org

JounQin
JounQin reviewed Dec 8, 2023
View reviewed changes
package.json Outdated
"aphrodite": "^2.4.0",
"on-change": "^4.0.2",
"placement.js": "^1.0.0-beta.5",
"uplot": "^1.6.26"
Copy link
Copy Markdown
Member

@JounQin JounQin Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好奇为啥要有两套图表引擎？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JounQin JounQin JounQin requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zChanges @JounQin @github-advanced-security