feat(config): new credentials model and profile deprecation#244
Draft
LorrisSaintGenez wants to merge 7 commits into
Draft
feat(config): new credentials model and profile deprecation#244LorrisSaintGenez wants to merge 7 commits into
LorrisSaintGenez wants to merge 7 commits into
Conversation
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 88 |
| Duplication | 14 |
TIP This summary will be updated as you push new changes.
profile add/remove/setdefault still write config.toml; once state.toml exists (new storage model in use), changes to legacy profiles stop being honored in a future version — say so before executing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrates the CLI to a new credentials model (state.toml + OS keychain) and deprecates the legacy
config.toml-based profile system.state.toml store (#232): self-contained store for current application, per-app alias and
api_key_uuid; atomic save (temp file + rename).Per-app OS keychain (#233):
SaveAppSecrets/LoadAppSecretsinpkg/keychain; neutral package to avoid import cycles withpkg/config.API key UUID (#234):
CreateAPIKeyreturnsCreatedAPIKey{Value, UUID};Application.APIKeyUUIDpopulated byEnsureAPIKey.Read resolution (#235): credential getters rewired — env → flag → state.toml + keychain → config.toml → admin fallback. Active app resolved once per command; keychain loaded once and cached.
Write paths (#236):
auth login,application createandapplication selectpersist to the new model (keychain first, then state.toml);config.tomlno longer written. Existing keys reused.auth crawlerstores the crawler key in the per-app keychain entry.Deprecations (#237):
--profileflag and allprofilesubcommands marked deprecated with replacement hints; auth failure hint updated; all user-facing strings reworded from "CLI profile" to the new model.Extra warning on legacy writes (26ae179): when
state.tomlalready exists (new storage model in use),profile add/remove/setdefaultprint an additional warning that changes toconfig.tomlprofiles will be ignored in a future version.Test
make build, then:GROUT-305