fix(telemetry): identify only after login/signup - #277
Open
LorrisSaintGenez wants to merge 5 commits into
Open
Conversation
LorrisSaintGenez
marked this pull request as ready for review
July 30, 2026 22:08
LorrisSaintGenez
marked this pull request as draft
July 30, 2026 22:09
LorrisSaintGenez
marked this pull request as ready for review
July 30, 2026 22:11
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 14 |
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
IdentifyfromPersistentPreRunE: a singleIdentifyis now emitted at command completion when the run established or renewed the session (login, signup, account switch, re-authentication, silent token refresh)version,operating_system,configured_applicationsandis_cias non-overridable base props on everyTrackevent, so per-event analytics keep working now that traits refresh only on session changesTest
Login path still identifies:
DEBUG=1 ./algolia auth login→ one{identifyline at the end of the run. (ALGOLIA_CLI_TELEMETRYmust be unset; source builds land in the dev Segment source https://app.segment.com/algolia-app/sources/segment_cli_dev/debugger)