display alert colors only for affected graph #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, all graphs of a bar plot series change color if the value of one of them is above a global threshold. This commit - adds individual threshold values for sensors, analog to measurements. - populates those individual thresholds with either sensor.high within temp_source or uses the default if not - then uses those indivudual thresholds to change colors of individual graphs within a bar plot. This gives users a better understanding of which sensor(s) was/were the reason for the 'alarm'. It does not use individual colors for only those bars that are above the threshold but always changes the color for all of the bars of one graph. While it would be nicer to have only those individual bars change color, I am afraid implementing this is beyond my current time budet and not as critial as seeing which of the sensors is poses the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, all graphs of a bar plot series change color if the value of one of them is above a global threshold.
This commit
This gives users a better understanding of which sensor(s) was/were the reason for the 'alarm'.
It does not use individual colors for only those bars that are above the threshold but always changes the color for all of the bars of one graph. While it would be nicer to have only those individual bars change color, I am afraid implementing this is beyond my current time budet and not as critial as seeing which of the sensors is poses the problem.
I believe this closes the following two:
Closes #121
Closes #193