add post process to make timecode subtitles#944
Conversation
05a73b6 to
c791c99
Compare
vrecord
Outdated
| fi | ||
|
|
||
| # make a timecode vtt | ||
| if [[ "${TIMECODEVTT_CHOICE}" = "true" ]] && [[ "${FORMAT}" = "matroska" ]] && [[ -n "${TIMECODE_CHOICE}" ]] && [[ "${TIMECODE_CHOICE}" != "none" ]] ; then |
There was a problem hiding this comment.
matroska > Matroska ?
like in line 2958
There was a problem hiding this comment.
thx, i dropped that commit
|
testing requires a daily build of mediainfo so til there's a new release run and also run |
c791c99 to
dc33c9e
Compare
|
Ready for testing and review, but we need to wait on a mediainfo release to merge. There's also an issue in ffmpeg-ma where it will only detect timecode when timecode_format is set to 'all'. @JeromeMartinez and I are working on this, for now please test with timecode set to all. |
|
I tested this PR and it worked, however there were a few dependencies. I had to install the latest daily build of mediainfo as suggested by @dericed. I also had to manually install timecodexml2webvtt by running |
e27ccfd to
cf8f9f8
Compare
splits the concept into caption and timecode
|
Still needs |
requires the next ffmpeg-ma version with matroska timecode captures