Closed
Conversation
Switch from firebase-admin to @google-cloud/firestore for reading votes data at build time. Remove credentials file handling and related Dockerfile steps. Simplify environment variable usage.
- Delete VotesRepository and related imports/usages - Update types to require votes fields (not optional) - Fetch votes in build-data script and include in static tools data - Simplify vote percentage display logic in components - Always show upvote percentage in UI - Set API votes endpoint to no-store cache - Remove dynamic votes fetching from static props - Update sorting and utility functions for new vote fields
logic - Language filter now supports radio mode for single-language selection - Sidebar merges popular and all languages into one radio group - Filtering logic updated to only match tools with exactly one language when a single language is selected - Popularity sorting now deprioritizes deprecated tools
- Update Node.js version to 24 in Dockerfile and GitHub Actions - Use BuildKit secret for GCP credentials during Docker build - Add docker-build target to Makefile - Include upVotes, downVotes, and upvotePercentage in Algolia index
Switch Cloud Run location to config value in YAML files. Require IMAGE_NAME and ALGOLIA_API_KEY as environment variables. Replace IAM policy with IAM member for public invoker access. Update Go version to 1.21.
Simpler and we don't need the additional knobs.
Member
Author
|
Superseded by #93 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.