Skip to content

Style: enforce official ktlint formatting and unify root .editorconfig#28

Open
calebareeveso wants to merge 1 commit into
android:mainfrom
calebareeveso:add-spotless-config
Open

Style: enforce official ktlint formatting and unify root .editorconfig#28
calebareeveso wants to merge 1 commit into
android:mainfrom
calebareeveso:add-spotless-config

Conversation

@calebareeveso

@calebareeveso calebareeveso commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

What I added

  • Added root .editorconfig: Enforces ktlint_code_style = ktlint_official and ignores function naming on @Composable functions across all projects.
  • Configured Spotless & Removed Overrides: Pointed agent and ChatApp Gradle files directly to the root .editorconfig (setEditorConfigPath) and deleted localized subfolder overrides.
  • Fixed Spotless Errors: Renamed BuiltInAppFunctions.kt to BaseBuiltInAppFunctionService.kt and FakeAppFunctions.kt to BaseFakeAppFunctionService.kt to match the class names brought in by pulling from upstream (1.0.0-alpha10). This is because ktlint_official throws a standard:filename Spotless build error when a file's name does not match the single class inside it.
  • Updated README Documentation: Updated README.md under "Code Style" to explicitly clarify that Spotless must be run using individual subproject wrappers when executed from the repository root (./agent/gradlew -p agent spotlessApply && ./ChatApp/gradlew -p ChatApp spotlessApply).
  • Applied Baseline Formatting: Ran spotlessApply across all modules (agent and ChatApp).

Change-Id: I3e8607d55a25a55bd3222b3f2a6d95e1a8c59aea

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a root-level .editorconfig file configured with the official ktlint code style and updates the Spotless configurations in both the ChatApp and agent build files to reference it. Consequently, various Kotlin source files, tests, and build scripts have been reformatted to comply with these styling rules, including adjustments to imports, line wrapping, and spacing. Additionally, the README.md has been updated with instructions on how to run Spotless formatting across the separate Gradle projects. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants