Skip to content

Migrate Jetcaster to AGP 9.0#1642

Open
jaebaek wants to merge 1 commit intoandroid:mainfrom
jaebaek:main
Open

Migrate Jetcaster to AGP 9.0#1642
jaebaek wants to merge 1 commit intoandroid:mainfrom
jaebaek:main

Conversation

@jaebaek
Copy link

@jaebaek jaebaek commented Feb 2, 2026

GiAS prepared this by relying on AKB tools.

GiAS prepared this by relying on AKB tools.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jaebaek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on upgrading the Jetcaster project to the latest Android Gradle Plugin (AGP) version 9.0.0. This significant update streamlines the build process by integrating Kotlin support directly into AGP, eliminating the need for explicit kotlin-android plugin declarations across various modules. The changes also include necessary updates to the Gradle wrapper and several core dependencies, ensuring compatibility and leveraging the latest features and improvements in the Android development ecosystem.

Highlights

  • Android Gradle Plugin (AGP) Upgrade: The project has been migrated to Android Gradle Plugin (AGP) version 9.0.0, which is the core change of this pull request.
  • Kotlin Android Plugin Removal: The explicit application of the kotlin-android plugin has been removed from the root build.gradle.kts and all module-level build.gradle.kts files. This is consistent with AGP 9.0's integrated Kotlin support.
  • Gradle Wrapper Update: The Gradle wrapper has been updated to version 9.1.0, aligning with the new AGP version.
  • Dependency Updates: Several key dependencies have been updated, including Hilt to 2.59, Roborazzi to 1.58.0, and Room to 2.8.4.
  • Wear Module Specific Changes: The wear module's compileSdk has been updated to 36, its Kotlin compiler options have been refactored to the new kotlin { compilerOptions { ... } } syntax, and the androidx.wear.compose.material dependency has been removed.
  • Gradle Properties Configuration: A new property android.disallowKotlinSourceSets=false has been added to gradle.properties to suppress potential errors related to Kotlin source sets with AGP 9.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the Jetcaster project to Android Gradle Plugin 9.0. The changes are mostly correct, including updating Gradle, AGP, and other dependencies, and adapting to the new plugin structure. However, I've found a critical issue where a Gradle property is being added that is actually removed in AGP 9.0, which will cause the build to fail. I've also suggested a small improvement for maintainability in one of the build scripts. Please address these points to finalize the migration.

Comment on lines +40 to +42

# Suppress error regarding kotlin.sourceSets with built-in Kotlin in AGP 9.0
android.disallowKotlinSourceSets=false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The android.disallowKotlinSourceSets property has been removed in Android Gradle Plugin 9.0.0 and is no longer recognized. Adding it to your gradle.properties file will cause a build failure. This property should be removed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not true. I built the APK and ran it on my local machine. It worked fine.

Could you please give me the reference where you see this information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant