Open
Conversation
hawkgs
force-pushed
the
drop-protractor
branch
from
42c9e3a to
27f9810
Compare
hawkgs
commented
Feb 24, 2026
Member
|
Can you also split this into two commits? |
Protractor is no longer supported and has been deprecated since v19.
Remove Protractor since it's no longer supported and has been deprecated since v19; Remove the dependency.
hawkgs
force-pushed
the
drop-protractor
branch
from
27f9810 to
fb465eb
Compare
alan-agius4
added
the
action: review
alan-agius4
reviewed
Feb 25, 2026
| @@ -49,11 +49,6 @@ ts_json_schema( | |||
| src = "src/builders/karma/schema.json", | |||
Collaborator
There was a problem hiding this comment.
Please remove Protractor from https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/README.md
| export type ServeBuilderTarget = BuilderTarget<Builders.DevServer, ServeBuilderOptions>; | ||
| export type ExtractI18nBuilderTarget = BuilderTarget<Builders.ExtractI18n, ExtractI18nOptions>; | ||
| export type E2EBuilderTarget = BuilderTarget<Builders.Protractor, E2EOptions>; | ||
| export type E2EBuilderTarget = BuilderTarget<E2eExternalBuilders, E2EOptions>; |
Collaborator
There was a problem hiding this comment.
We no longer need this, also remove E2EOptions
Suggested change
| export type E2EBuilderTarget = BuilderTarget<E2eExternalBuilders, E2EOptions>; |
| } | ||
|
|
||
| export interface BuilderTarget<TBuilder extends Builders, TOptions> { | ||
| export interface BuilderTarget<TBuilder extends Builders | E2eExternalBuilders, TOptions> { |
Collaborator
There was a problem hiding this comment.
Suggested change
| export interface BuilderTarget<TBuilder extends Builders | E2eExternalBuilders, TOptions> { | |
| export interface BuilderTarget<TBuilder extends Builders, TOptions> { |
Comment on lines
+41
to
+52
| /** | ||
| * An enum of E2E external builders. | ||
| * Each enum value provides the fully qualified name of the associated builder. | ||
| */ | ||
| enum E2eExternalBuilders { | ||
| Playwright = 'playwright-ng-schematics:playwright', | ||
| Cypress = '@cypress/schematic:cypress', | ||
| Nightwatch = '@nightwatch/schematics:nightwatch', | ||
| WebdriverIO = '@wdio/schematics:wdio', | ||
| Puppeteer = '@puppeteer/ng-schematics:puppeteer', | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| /** | |
| * An enum of E2E external builders. | |
| * Each enum value provides the fully qualified name of the associated builder. | |
| */ | |
| enum E2eExternalBuilders { | |
| Playwright = 'playwright-ng-schematics:playwright', | |
| Cypress = '@cypress/schematic:cypress', | |
| Nightwatch = '@nightwatch/schematics:nightwatch', | |
| WebdriverIO = '@wdio/schematics:wdio', | |
| Puppeteer = '@puppeteer/ng-schematics:puppeteer', | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Drop Protractor from the respository since it's no longer supported.
Does this PR introduce a breaking change?