feat(ng-dev): add sync-module-bazel command to update pnpm and typescript versions and integrity in MODULE.bazel
#3340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: merge
alan-agius4
force-pushed
the
sync-bazel
branch
from
5153813 to
dc9872e
Compare
alan-agius4
added
action: review
josephperrott
previously requested changes
Jan 8, 2026
…ypescript` versions and integrity in `MODULE.bazel` This is helpful to ensure that these versions are always synced.
alan-agius4
force-pushed
the
sync-bazel
branch
from
dc9872e to
67a9f7b
Compare
alan-agius4
force-pushed
the
sync-bazel
branch
2 times, most recently
from
c9c20e4 to
8eb6661
Compare
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Jan 9, 2026
This will be handled in dev-infra preset, see: angular/dev-infra#3340
alan-agius4
force-pushed
the
sync-bazel
branch
2 times, most recently
from
a5377cc to
de575ef
Compare
alan-agius4
commented
Jan 9, 2026
| "24.11.0-linux_amd64": ("node-v24.11.0-linux-x64.tar.xz", "node-v24.11.0-linux-x64", "46da9a098973ab7ba4fca76945581ecb2eaf468de347173897044382f10e0a0a"), | ||
| "24.11.0-windows_amd64": ("node-v24.11.0-win-x64.zip", "node-v24.11.0-win-x64", "1054540bce22b54ec7e50ebc078ec5d090700a77657607a58f6a64df21f49fdd"), | ||
| }, | ||
| node_version = "24.11.0", |
Contributor
Author
There was a problem hiding this comment.
Using node_version_from_nvmrc in dev-infra causes build failures because pnpm ng-dev sync-module-bazel executes inside Bazel. To prevent errors during syncing, we must ensure the Node.js toolchain is correctly configured before actually syncing. Thus, we update the node_version with that inside the .nvmrc during syncing.
alan-agius4
force-pushed
the
sync-bazel
branch
from
de575ef to
f4c65c8
Compare
… and `typescript` versions and integrity in `MODULE.bazel`
alan-agius4
force-pushed
the
sync-bazel
branch
from
f4c65c8 to
e2c8384
Compare
josephperrott
approved these changes
Jan 9, 2026
Member
josephperrott
left a comment
josephperrott
left a comment
There was a problem hiding this comment.
LGTM
Just the one thing noted here.
… and `typescript` versions and integrity in `MODULE.bazel`
alan-agius4
added
action: merge
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Jan 9, 2026
This will be handled in dev-infra preset, see: angular/dev-infra#3340
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
thePunderWoman
pushed a commit
to angular/angular
that referenced
this pull request
Jan 9, 2026
This will be handled in dev-infra preset, see: angular/dev-infra#3340
thePunderWoman
pushed a commit
to angular/angular
that referenced
this pull request
Jan 9, 2026
This will be handled in dev-infra preset, see: angular/dev-infra#3340 (cherry picked from commit 99db2e9)
thePunderWoman
pushed a commit
to angular/angular
that referenced
this pull request
Jan 9, 2026
This will be handled in dev-infra preset, see: angular/dev-infra#3340 (cherry picked from commit 99db2e9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful to ensure that these versions are always synced.