fix(core): respect whitelist when filtering deprecated models#15539
Open
zerone0x wants to merge 1 commit intoanomalyco:devfrom
Open
fix(core): respect whitelist when filtering deprecated models#15539zerone0x wants to merge 1 commit intoanomalyco:devfrom
zerone0x wants to merge 1 commit intoanomalyco:devfrom
Conversation
Deprecated models were unconditionally deleted before the whitelist check, making it impossible to use whitelisted deprecated models like kimi-k2.5-free or glm-5-free. Now the deprecated filter skips models that appear in the provider's whitelist. Fixes anomalyco#15430 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #15430
Type of change
What does this PR do?
Models marked as
deprecatedwere unconditionally deleted from the provider's model list before the whitelist check ran. This meant that even if a user explicitly whitelisted a deprecated model (e.g.,kimi-k2.5-free,glm-5-free), it would be removed and never appear in the available models.The fix adds a whitelist guard to the deprecated-model deletion:
Now, if a model is both deprecated and explicitly listed in the provider's
whitelist, it is preserved. All other deprecated models are still deleted as before. The subsequent whitelist/blacklist filter (lines 1002-1006) continues to handle the general case.How did you verify your code works?
truewhen there is no whitelist)configProvider?.whitelist?.includes) safely handles missing config/whitelistChecklist
🤖 Generated with Claude Code