fix(core): guard against null event.seq when inserting session_messages#31419
Open
Cain-Brouwer wants to merge 1 commit into
Open
fix(core): guard against null event.seq when inserting session_messages#31419Cain-Brouwer wants to merge 1 commit into
Cain-Brouwer wants to merge 1 commit into
Conversation
The NOT NULL constraint on session_message.seq could be violated when event.seq is null instead of undefined. All projectors and message inserters checked event.seq === undefined, which only guards against undefined — null passed through and caused a SQLite constraint failure: NOT NULL constraint failed: session_message.seq This occurred during session.next.agent.switched handling, preventing the build agent from responding after switching from plan mode. Change all event.seq === undefined checks to event.seq == null to catch both null and undefined values.
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31204
Type of change
What does this PR do?
When switching from plan to build agent the db throws
NOT NULL constraint failed: session_message.seqbecauseevent.seqis null but the check only catches undefined. Changed all=== undefinedchecks onevent.seqto== null.How did you verify your code works?
Ran
bun testin packages/core — all existing tests pass.Checklist