fix(native-llm): replace hardcoded provider gate with shared support set#38894
Closed
mgajda wants to merge 1 commit into
Closed
fix(native-llm): replace hardcoded provider gate with shared support set#38894mgajda wants to merge 1 commit into
mgajda wants to merge 1 commit into
Conversation
Closes anomalyco#38893. The native LLM runtime's statusWithFetch() had a hardcoded allowlist of supported provider IDs and npm packages that excluded Google, Amazon Bedrock, Azure, and OpenRouter from the native path, even though native-request.ts had working adapters for them. Export SUPPORTED_NPM_PACKAGES from native-request.ts and use it in the gate so the two stay in sync by construction. Also fix API key propagation for providers with multiple env vars (GOOGLE_API_KEY, GOOGLE_GENERATIVE_AI_API_KEY, GEMINI_API_KEY) by removing the env.length === 1 guard — the found key is now always stored in provider.key.
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38893.
The native LLM runtime at
packages/opencode/src/session/llm/native-runtime.tshad a hardcoded allowlist instatusWithFetch()that blocked Google, Amazon Bedrock, Azure, and OpenRouter from the native LLM path, even thoughnative-request.tshad working adapters for them.The two lists were duplicated and had drifted apart as new providers were added.
Changes:
SUPPORTED_NPM_PACKAGESfromnative-request.ts(one source of truth)statusWithFetch()gate instead of hardcoded checksenv.length === 1guard that dropped keys for providers with multiple env vars (e.g. Google has GOOGLE_API_KEY, GOOGLE_GENERATIVE_AI_API_KEY, GEMINI_API_KEY)Verification: the native LLM path now accepts any provider whose npm package is in SUPPORTED_NPM_PACKAGES. Adding a new provider only requires updating the set in native-request.ts.