Fix task duration chart rendering issues in Airflow 3#63635
Draft
abhijeets25012-tech wants to merge 1 commit intoapache:mainfrom
Draft
Fix task duration chart rendering issues in Airflow 3#63635abhijeets25012-tech wants to merge 1 commit intoapache:mainfrom
abhijeets25012-tech wants to merge 1 commit intoapache:mainfrom
Conversation
- Add Legend import and registration for chart visibility - Add median duration reference line (blue dashed) - Fix Y-axis to show s/m/h instead of HH:MM:SS - Make chart full width with fixed height of 400px Fixes apache#63582
Member
|
@abhijeets25012-tech This PR has been converted to draft because it does not yet meet our Pull Request quality criteria. Issues found:
What to do next:
Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack. |
Contributor
|
We're going to need some screenshots here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #63582
The task duration chart in Airflow 3 had several rendering issues
compared to Airflow 2. This PR addresses all of them.
Changes Made
1. Chart Size
w="100%"to make chart full widthh="400px"fixed height wrappermaintainAspectRatio: falseso chart respects height2. Y-Axis Units
HH:MM:SSformat to human readables/m/h30s,5.2m,1.5hinstead of00:00:303. Median Duration Line
median()function to calculate median value4. Legend
Legendto Chart.js imports and registrationlegend: { display: true, position: "top" }to optionsScreenshots
Testing
npm run buildRelated Issue
Closes #63582