fix deadline callback migration to improve query performance#63640
Closed
wjddn279 wants to merge 2 commits intoapache:mainfrom
Closed
fix deadline callback migration to improve query performance#63640wjddn279 wants to merge 2 commits intoapache:mainfrom
wjddn279 wants to merge 2 commits intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:db-migrations
2 tasks
| UPDATE deadline2 | ||
| SET callback_id = v.callback_id, missed = v.missed | ||
| FROM (VALUES {values_clause}) AS v(deadline_id, callback_id, missed) | ||
| WHERE deadline2.id = v.deadline_id |
Contributor
There was a problem hiding this comment.
This fails on real data upgrade.
Contributor
Author
There was a problem hiding this comment.
Yes, there was a discussion about this, and it seems to fail depending on the environment. Since there's another PR with an alternative fix, I'll close this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
releated: #63532
Through my testing, I confirmed that the bottleneck of this migration is not serialization, but the update query being executed one row at a time.
Even after excluding all performance bottlenecks such as serialization (including Python dict deserialization), the query performance was still poor. By changing the update to a bulk update, I confirmed an improvement from 2,000 rows/sec to 40,000 rows/sec (PostgreSQL), and 20,000 rows/sec on MySQL.
Even though the existing serialization code had no significant impact on performance, so it was replaced with code that simply gets values from the existing column's dict. (slight performance improvement)
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.