Fix calendar view showing queued runs as green, indistinguishable from success#66621
Fix calendar view showing queued runs as green, indistinguishable from success#66621shashbha14 wants to merge 2 commits intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Thanks for working on this. I noticed a couple of cases that are not covered here yet: queued + actual runs in
the same Calendar cell, and queued-only runs still affecting calculateDataBounds() in Total Runs mode.
I opened #66623 with test coverage for the current Calendar behavior(bbcda03) and the queued-run cases(c94cdca), so feel free to reuse or cherry-pick the tests from there.
If we want to introduce a separate queued color, I think we should also define how that color should behave for mixed cells, such as queued + success or queued + failed, and make sure queued runs are excluded from the actual-run bounds calculation. That should make the behavior clear whichever color direction we choose.
I tested your code and captured the behavior in the screenshot below

Closes #66614
In the Calendar view (Total Runs), cells that have queued runs appear as solid green as those that have successful runs. It can be known via the tooltip.
The problem lies in calendarUtils.ts file where actualCount subtracts planned but not queued from total hence treating queued runs as successful runs, which causes queued runs to display as green.
Solution:
a particular cell.