Skip to content

Fix calendar view showing queued runs as green, indistinguishable from success#66621

Open
shashbha14 wants to merge 2 commits intoapache:mainfrom
shashbha14:fix/calendar-queued-color-66614
Open

Fix calendar view showing queued runs as green, indistinguishable from success#66621
shashbha14 wants to merge 2 commits intoapache:mainfrom
shashbha14:fix/calendar-queued-color-66614

Conversation

@shashbha14
Copy link
Copy Markdown
Contributor

Closes #66614
In the Calendar view (Total Runs), cells that have queued runs appear as solid green as those that have successful runs. It can be known via the tooltip.

The problem lies in calendarUtils.ts file where actualCount subtracts planned but not queued from total hence treating queued runs as successful runs, which causes queued runs to display as green.

Solution:

  • Subtract queued from actualCount like planned
  • Return a unique blue color whenever there are only queued runs in
    a particular cell.
  • Include queued color swatch to legend

I utilized Claude (claude.ai) as an AI assistant during this implementation process.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label May 9, 2026
@shashbha14 shashbha14 marked this pull request as ready for review May 9, 2026 13:03
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I noticed a couple of cases that are not covered here yet: queued + actual runs in
the same Calendar cell, and queued-only runs still affecting calculateDataBounds() in Total Runs mode.

I opened #66623 with test coverage for the current Calendar behavior(bbcda03) and the queued-run cases(c94cdca), so feel free to reuse or cherry-pick the tests from there.

If we want to introduce a separate queued color, I think we should also define how that color should behave for mixed cells, such as queued + success or queued + failed, and make sure queued runs are excluded from the actual-run bounds calculation. That should make the behavior clear whichever color direction we choose.

I tested your code and captured the behavior in the screenshot below
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Calendar view renders queued runs in solid green, indistinguishable from success

2 participants