Skip to content

Add regression tests for cli safe flash escaping#66622

Open
Sanskar121543 wants to merge 1 commit intoapache:mainfrom
Sanskar121543:fix-html-escaping-validation
Open

Add regression tests for cli safe flash escaping#66622
Sanskar121543 wants to merge 1 commit intoapache:mainfrom
Sanskar121543:fix-html-escaping-validation

Conversation

@Sanskar121543
Copy link
Copy Markdown

Summary

Adds regression coverage for _cli_safe_flash to verify:

  • HTML content is safely escaped before rendering in flash messages
  • CLI output formatting correctly converts HTML tags to terminal-safe text

Why

This helps prevent accidental unsafe rendering of user-controlled content in FAB auth manager flash messages.

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented May 9, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant